[fix] Issue with previously defined SQL configuration #9082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Feb 4, 2020
| d = params.get("connect_args", {}) | ||
| d["configuration"] = configuration | ||
| params["connect_args"] = d | ||
| connect_args["configuration"] = configuration |
There was a problem hiding this comment.
I simply renamed d to the more descriptive connect_args.
Codecov Report
@@ Coverage Diff @@
## master #9082 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11752 11752
Branches 2889 2889
=======================================
Hits 6987 6987
Misses 4586 4586
Partials 179 179Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--fix-sqlalchemy-configuration
branch
from
a2b0586
to
b2924f7
Compare
villebro
approved these changes
Feb 4, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The
get_sqla_enginemethod which mutates the URL overrides theconfigurationkey within the SQLAlchemyconnect_argsparams rather than updating it. This means that any database specific configuration options are simply ignored.This PR ensures that the configuration is updated rather than overridden.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Test locally on a Hive database and verified that PyHive was receiving the correct configuration.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @michellethomas @mistercrunch @villebro