Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adhoc metric bug in chord diagram #9149

Merged
merged 1 commit into from Feb 17, 2020
Merged

fix: adhoc metric bug in chord diagram #9149

merged 1 commit into from Feb 17, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Feb 15, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

The chord viz currently doesn't work with ad-hoc metrics due to the metric being replaced by the metric name.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

Tested locally to ensure that it works both with datasource metrics and ad-hoc metrics. Unit tests not added due to planned refactoring of viz.py in the near future.

ADDITIONAL INFORMATION

REVIEWERS

@hefeng11725 @mtomov

@codecov-io
Copy link

Codecov Report

Merging #9149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9149   +/-   ##
=======================================
  Coverage   59.06%   59.06%           
=======================================
  Files         372      372           
  Lines       11922    11922           
  Branches     2919     2919           
=======================================
  Hits         7042     7042           
  Misses       4698     4698           
  Partials      182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95a867...ba1461d. Read the comment docs.

@craig-rueda craig-rueda merged commit 114642d into apache:master Feb 17, 2020
@villebro villebro deleted the chord branch February 17, 2020 05:35
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chord Diagram get Metric 'SUM(redu)' does not exist
5 participants