Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSX Menu links open in new tab #9191

Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Feb 22, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

When the new React navbar was built, the functionality of bug reporting and documentation links opening in a new tab wasn't ported over. This fixes it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

looks like this before and after:
image

TEST PLAN

Set the config value for the DOCUMENTATION_URL, click the link, see it open in another tab

See other links open in the current tab as before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @willbarrett @graceguo-supercat @john-bodley @zuzana-vej

@codecov-io
Copy link

Codecov Report

Merging #9191 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9191   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files         372      372           
  Lines       11938    11938           
  Branches     2925     2925           
=======================================
  Hits         7059     7059           
  Misses       4699     4699           
  Partials      180      180
Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.jsx 87.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efdfc5...5e1755b. Read the comment docs.

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Love the ABC!

@etr2460 etr2460 merged commit 78b1561 into apache:master Feb 23, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants