Make JSX Menu links open in new tab #9191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
When the new React navbar was built, the functionality of bug reporting and documentation links opening in a new tab wasn't ported over. This fixes it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
looks like this before and after:
TEST PLAN
Set the config value for the DOCUMENTATION_URL, click the link, see it open in another tab
See other links open in the current tab as before
ADDITIONAL INFORMATION
REVIEWERS
to: @willbarrett @graceguo-supercat @john-bodley @zuzana-vej