[Bug Fix] Returning timeseries_limit_metric in table viz get_data #9196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9196 +/- ##
==========================================
- Coverage 58.93% 58.91% -0.03%
==========================================
Files 372 372
Lines 11987 11992 +5
Branches 2936 2936
==========================================
Hits 7065 7065
- Misses 4742 4749 +7
+ Partials 180 178 -2
Continue to review full report at Codecov.
|
michellethomas
changed the title
There was a problem hiding this comment.
@michellethomas apologies for the regression. Do you think it would be possible to augment the test case to add the timeseries limit metric?
|
@john-bodley also needed to fix a similar issue with the include_time field too. I added a test for the timeseries_limit_metric. I'll add a test for include_time in a follow up PR. |
|
|
||
| non_percent_metric_columns.extend( | ||
| utils.get_metric_names(self.form_data.get("metrics") or []) | ||
| ) |
There was a problem hiding this comment.
How are lines 588 - 594 different to what was previously on lines 584 - 586?
There was a problem hiding this comment.
I'm just extending them separately because it feels a bit more readable, rather than extending list + list.
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
This change update the table viz's get_data, but was missing returning the timeseries_limit_metric (sort_by). If a metric has a custom label and a sort by field, not returning the sort_by field doesn't show the metric.
TEST PLAN
Tested a metric with a label and a sort by field
ADDITIONAL INFORMATION
REVIEWERS
@john-bodley