Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard perf logging] add dashboard url anchor component id #9202

Merged

Conversation

graceguo-supercat
Copy link

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Dashboard supports nested tabs and charts. But user can add anchor in the request url, and dashboard will be landed with the component in the anchor. For example:
https://superset.d.musta.ch/superset/dashboard/homes/#TAB-DZy3k25d_ will open a specific tab.
https://superset.d.musta.ch/superset/dashboard/homes/#CHART-59WSceLod1 will open a specific chart.

This PR is to add the anchor component into dashboard perf log, so that we can see which tab/charts are more popular. This will help dashboard warm-up tasks.

TEST PLAN

CI and manual test.

REVIEWERS

@serenajiang @etr2460

@codecov-io
Copy link

Codecov Report

Merging #9202 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9202      +/-   ##
==========================================
+ Coverage   58.91%   58.91%   +<.01%     
==========================================
  Files         372      372              
  Lines       11992    11996       +4     
  Branches     2936     2937       +1     
==========================================
+ Hits         7065     7068       +3     
- Misses       4749     4750       +1     
  Partials      178      178
Impacted Files Coverage Δ
...et-frontend/src/dashboard/components/Dashboard.jsx 84.37% <80%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1992069...1537fa5. Read the comment docs.

Copy link
Contributor

@serenajiang serenajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust u

@graceguo-supercat graceguo-supercat merged commit 883b0d0 into apache:master Feb 26, 2020
@graceguo-supercat graceguo-supercat deleted the gg-AddDashAnchorToLog branch June 11, 2020 23:20
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants