Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard, chart] fix ordering and filtering in listviews #9212

Merged
merged 3 commits into from Feb 27, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Feb 26, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fixes issues with ordering and filtering on dashboard and chart listviews

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@dpgaspar @craig-rueda @mistercrunch

@nytai nytai changed the title [dashboard, chart] fix ordering and filtering [dashboard, chart] fix ordering and filtering in listviews Feb 26, 2020
@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #9212 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9212      +/-   ##
==========================================
+ Coverage   58.91%   58.92%   +0.01%     
==========================================
  Files         372      372              
  Lines       11996    11999       +3     
  Branches     2937     2940       +3     
==========================================
+ Hits         7068     7071       +3     
  Misses       4750     4750              
  Partials      178      178
Impacted Files Coverage Δ
...frontend/src/views/dashboardList/DashboardList.tsx 59.34% <ø> (ø) ⬆️
...ontend/src/components/ListView/TableCollection.tsx 90% <100%> (+1.11%) ⬆️
...uperset-frontend/src/views/chartList/ChartList.tsx 63.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f73f8a...979e47f. Read the comment docs.

@mistercrunch
Copy link
Member

Weird, travis is green but merge is yellow, trying to close/reopen

@craig-rueda craig-rueda merged commit cd4605e into apache:master Feb 27, 2020
@craig-rueda craig-rueda deleted the tai/fix-listviews branch February 27, 2020 17:30
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants