fix: choose language link for local dev #9215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9215 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 372 372
Lines 11996 11996
Branches 2937 2937
=======================================
Hits 7068 7068
Misses 4750 4750
Partials 178 178
Continue to review full report at Codecov.
|
|
@rusackas this looks like a nice fix, might be up your alley for a review |
ktmud
force-pushed
the
fix-choose-lang-link
branch
from
d29e8a3
to
27af09d
Compare
nytai
approved these changes
Mar 2, 2020
| @@ -67,7 +67,7 @@ export default function setupApp() { | |||
| ) { | |||
| ev.preventDefault(); | |||
| SupersetClient.get({ | |||
| endpoint: ev.currentTarget.href, | |||
| url: ev.currentTarget.href, | |||
There was a problem hiding this comment.
Are we sure that the url will always be a full url instead of a relative one?
There was a problem hiding this comment.
Even if it's not, SupersetClient should still be able to handle it. fetch does accept relative URLs.
@superset-ui/connection will add protocol and host to an "endpoint" call. `e.currentTarget.href` may return the full URL instead of the relative url.
ktmud
force-pushed
the
fix-choose-lang-link
branch
from
27af09d
to
b3854af
Compare
7 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
@superset-ui/connection will add protocol and host to an "endpoint" call.
e.currentTarget.hrefmay return the full URL instead of the relative url. This sometimes results in invalid URLs for change language API calls.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In local dev environment, change language will result in a 404 error:
The result should be gone after this fix.
TEST PLAN
Change language in local dev box will work and should not throw an error in the browser console.
ADDITIONAL INFORMATION
N/A
REVIEWERS
@kristw