[fix] Adding SIP-15 support for the query context #9219
Conversation
| @@ -973,7 +984,12 @@ def test_results_default_deserialization(self): | |||
| "sql": "SELECT * FROM birth_names LIMIT 100", | |||
| "status": utils.QueryStatus.PENDING, | |||
| } | |||
| serialized_data, selected_columns, all_columns, expanded_columns = sql_lab._serialize_and_expand_data( | |||
| ( | |||
There was a problem hiding this comment.
This is black formatting.
| @@ -1016,7 +1032,12 @@ def test_results_msgpack_deserialization(self): | |||
| "sql": "SELECT * FROM birth_names LIMIT 100", | |||
| "status": utils.QueryStatus.PENDING, | |||
| } | |||
| serialized_data, selected_columns, all_columns, expanded_columns = sql_lab._serialize_and_expand_data( | |||
| ( | |||
There was a problem hiding this comment.
This is black formatting.
There was a problem hiding this comment.
LGTM as quick fix, however I wonder if we should try to establish conventions for what should go into extras and what warrants a dedicated attribute, e.g. relative_start, relative_end etc, which IMO seem very much like extras. FYI @rusackas re: viz.py deprecation
|
@villbro I agree. I’m not sure what the original intent was for |
|
Looking at the current signature, I feel comfortable with most of the other parameters, but the |
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
This PR ensures that the query context sets the query time range endpoints if undefined and SIP-15 is enabled.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Added unit test.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @villebro