Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Oracle fetch_query and datetime conversion #9240

Merged
merged 1 commit into from Mar 4, 2020
Merged

fix: Oracle fetch_query and datetime conversion #9240

merged 1 commit into from Mar 4, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Mar 4, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

The Oracle spec extended PostgresBaseEngineSpec, which didn't really make any sense, as Oracle has very little in common with Postgres. As FixedOffsetTimezone was added to PostgresBaseEngineSpec recently, data fetching was consequently broken, as it isn't needed for Oracle. Changes in this PR:

  • OracleEngineSpec now extends BaseEngineSpec. This fixes fetch_data.
  • Epoch (second and ms) expressions were implemented and tested to work
  • DATETIME expression was added + unit test

TEST PLAN

Test locally + CI

ADDITIONAL INFORMATION

  • Has associated issue: closes Oracle "ORA-00907: missing right parenthesis" error #4058 #9237 . The issue reported was actually already fixed, but it exposed the regression and shortcomings that are addressed here.
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

craig-rueda
craig-rueda approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 969bc87 into apache:master Mar 4, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle "ORA-00907: missing right parenthesis" error #4058
4 participants
@villebro @willbarrett @craig-rueda @mistercrunch