Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update release testing FLASK_APP #9254

Merged
merged 1 commit into from Mar 7, 2020
Merged

fix: update release testing FLASK_APP #9254

merged 1 commit into from Mar 7, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Mar 7, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Since the 0.35 release, FLASK_APP needs to call the create_app() method. See #8621

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@villebro villebro requested a review from dpgaspar March 7, 2020 09:35
@villebro
Copy link
Member Author

villebro commented Mar 7, 2020

Going to merge this to unblock the release process, I don't feel comfortable doing a release without doing this step by the book.

@villebro villebro merged commit 0faced7 into apache:master Mar 7, 2020
@dpgaspar
Copy link
Member

dpgaspar commented Mar 7, 2020

Factory app pattern is a new thing on 0.36. There may be a few more like this.

LGTM

villebro added a commit that referenced this pull request Mar 7, 2020
@villebro
fix: update release testing FLASK_APP param (#9254)
4c9f4e5
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@villebro @dpgaspar @mistercrunch