Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ACE editor font jank (again?!) #9264

Merged
merged 1 commit into from Mar 9, 2020

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Mar 9, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fixes #9253

Playing whack-a-mole with a font width/tracking issue in ACE editor(s). Tried to fix it in Safari, which seemed to work, but somehow now causes issue in Chrome. Undoing the fix, with a net delta of a new typeface, SEEMS to me, to work in both Chrome AND Safari, but I feel like I could use a sanity check from @etr2460 or anyone else.

Also of note, react-ace is on v5 in Superset, where they're on v8. I tried upgrading, and ran into all sorts of upgrade woes. It DID seem to solve solve this font width issue, however. I'll try to make an upgrade somewhere between v6 and v8 on a separate PR, so heads up about that, and speak up with any experience/warnings/objections if you have them.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Chrome:
chrome

Safari:
safari

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@etr2460

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the fix in chrome and it lgtm

@codecov-io
Copy link

Codecov Report

Merging #9264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9264   +/-   ##
======================================
  Coverage    58.9%   58.9%           
======================================
  Files         373     373           
  Lines       12026   12026           
  Branches     2953    2953           
======================================
  Hits         7084    7084           
  Misses       4763    4763           
  Partials      179     179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5b898...6aa1719. Read the comment docs.

@etr2460 etr2460 merged commit d8fea64 into apache:master Mar 9, 2020
@willbarrett willbarrett deleted the ACE-editor-font-jank branch March 9, 2020 19:57
@villebro villebro added the v0.36 label Mar 10, 2020
@mapshen mapshen mentioned this pull request Jul 16, 2021
3 tasks
@MichaelHintz MichaelHintz mentioned this pull request Sep 7, 2022
3 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.36 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor falls behind in SQL Lab
5 participants