[Charts] Use the Edit Properties modal throughout React views

[suddjian]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

The Edit Properties modal previously belonging only to the Explore dropdown is now used in the two additional places. This change replaces links to the CRUD edit page for charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@nytai @etr2460 @rusackas

[rusackas]

Couple o' random questions, but LGTM.

[codecov-io]

Codecov Report

Merging #9267 into master will decrease coverage by 0.01%.
The diff coverage is 35.59%.

@@            Coverage Diff             @@
##           master    #9267      +/-   ##
==========================================
- Coverage    58.9%   58.88%   -0.02%     
==========================================
  Files         373      373              
  Lines       12026    12069      +43     
  Branches     2953     2957       +4     
==========================================
+ Hits         7084     7107      +23     
- Misses       4763     4783      +20     
  Partials      179      179

Impacted Files	Coverage Δ
...tend/src/explore/components/ExploreChartHeader.jsx	65.3% <45.45%> (-5.75%)	⬇️
...tend/src/explore/components/DisplayQueryButton.jsx	50.66% <50%> (-0.73%)	⬇️
...uperset-frontend/src/views/chartList/ChartList.tsx	62.9% <66.66%> (+0.17%)	⬆️
...rontend/src/explore/components/PropertiesModal.tsx	11.76% <7.69%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f0d45...3798a78. Read the comment docs.

[rusackas]

LGTM