[fix] copy filter_scopes with duplicate charts

[graceguo-supercat]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

in code refactor PR #9224, it introduced a bug:
https://github.com/apache/incubator-superset/blob/7a91498cf1a9e56d4b3d7b3805076137525ea277/superset/views/core.py#L1293
here we should use old slice's id as key instead of sid which is new or copied slice's id

TEST PLAN

fixed unit test.

ADDITIONAL INFORMATION

• Has associated issue: refactor copy filter_scopes and add tests #9224

REVIEWERS

@serenajiang @john-bodley

[codecov-io]

Codecov Report

Merging #9271 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #9271      +/-   ##
=========================================
- Coverage   58.93%   58.9%   -0.03%     
=========================================
  Files         373     373              
  Lines       12014   12026      +12     
  Branches     2945    2953       +8     
=========================================
+ Hits         7080    7084       +4     
- Misses       4755    4763       +8     
  Partials      179     179

Impacted Files	Coverage Δ
...t-frontend/src/dashboard/actions/dashboardState.js	30.66% <0%> (-1.06%)	⬇️
...uperset-frontend/src/views/chartList/ChartList.tsx	62.72% <0%> (-0.67%)	⬇️
superset-frontend/src/chart/Chart.jsx	10.41% <0%> (ø)	⬆️
...erset-frontend/src/dashboard/components/Header.jsx	41.79% <0%> (ø)	⬆️
...d/src/dashboard/components/SliceHeaderControls.jsx	11.62% <0%> (ø)	⬆️
.../src/dashboard/components/gridComponents/Chart.jsx	67.41% <0%> (ø)	⬆️
...-frontend/src/dashboard/components/SliceHeader.jsx	24% <0%> (ø)	⬆️
...nd/src/dashboard/containers/DashboardComponent.jsx	92% <0%> (ø)	⬆️
...ashboard/components/gridComponents/ChartHolder.jsx	79.66% <0%> (ø)	⬆️
superset-frontend/src/chart/chartAction.js	43.87% <0%> (+0.53%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a91498...45d25cf. Read the comment docs.