New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table-chart): bump legacy-table-chart to 0.11.18 #9275
Conversation
@@ -7670,28 +7670,28 @@ | |||
"dependencies": { | |||
"abbrev": { | |||
"version": "1.1.1", | |||
"resolved": false, | |||
"resolved": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the resolved is updated to empty string? Still a fresh npm ci
though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
Codecov Report
@@ Coverage Diff @@
## master #9275 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 373 373
Lines 12026 12026
Branches 2953 2953
=======================================
Hits 7084 7084
Misses 4763 4763
Partials 179 179 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -7670,28 +7670,28 @@ | |||
"dependencies": { | |||
"abbrev": { | |||
"version": "1.1.1", | |||
"resolved": false, | |||
"resolved": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
CATEGORY
SUMMARY
The new table chart implementation added in #9269 and #9234 throws a JS error when query results are empty but the metric list is not empty.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: there is a JS error when query results are empty for a table visualization with metrics:
After: it should show "no data available in table".
TEST PLAN
ADDITIONAL INFORMATION
N/A
REVIEWERS
cc: @etr2460 @kristw @graceguo-supercat