Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard][api] Fix, PUT publish/draft to not clean slug and owners #9279

Merged
merged 4 commits into from Mar 12, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Mar 11, 2020

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fix bug on the dashboard API, "Draft" Button Clears Slug and Owners from Dashboard.

Note: We are planning to refactor this soon to comply to SIP-35

TEST PLAN

Create a new dashboard with a slug and several owners, then publish the dashboard using the dashboard view itself. Verify that slug and owner do not get cleaned

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 11, 2020
@dpgaspar dpgaspar marked this pull request as ready for review March 11, 2020 10:17
@codecov-io
Copy link

Codecov Report

Merging #9279 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9279   +/-   ##
=======================================
  Coverage   58.90%   58.90%           
=======================================
  Files         373      373           
  Lines       12026    12026           
  Branches     2953     2953           
=======================================
  Hits         7084     7084           
  Misses       4763     4763           
  Partials      179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406ad87...126a3eb. Read the comment docs.

@dpgaspar dpgaspar added the v0.36 label Mar 11, 2020
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be simplified slightly?

superset/views/dashboard/api.py Outdated Show resolved Hide resolved
@dpgaspar dpgaspar requested a review from villebro March 11, 2020 13:33
@dpgaspar dpgaspar merged commit 78ba7d5 into apache:master Mar 12, 2020
@dpgaspar dpgaspar deleted the fix/api-dashboard-publish branch March 12, 2020 15:35
@milimetric
Copy link

We're seeing an issue and it seems related to this change, but I'd like to verify. So the behavior we're seeing is:

  • User makes a new dashboard
  • Clicks Draft button
  • (sometimes) is prompted to log in
  • (sometimes) is not prompted to log in
  • (always) gets a 401 error with the message {"message":"Access is Denied","severity":"danger"}

Would this be fixed after we get this change?

@milimetric
Copy link

Gengle ping, can @dpgaspar or anyone else chime in?

@milimetric
Copy link

UPDATE: this issue went away when we upgraded to version 0.36

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v0.36 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants