Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix, related fields need to be explicitly defined #9283

Merged
merged 3 commits into from Mar 12, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Mar 11, 2020

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

No problem found. But it's better to play safe and by default lock down the generic related endpoint. So, now we need to explicitly define the related fields we want to expose

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

superset/datasets/api.py Outdated Show resolved Hide resolved
Co-Authored-By: ʈᵃᵢ <tdupreetan@gmail.com>
@dpgaspar dpgaspar merged commit 0c8c4d6 into apache:master Mar 12, 2020
@dpgaspar dpgaspar deleted the fix/api-related-lock branch March 12, 2020 18:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants