Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-Compose Memory Issue Fix? #9285

Merged
merged 2 commits into from Mar 13, 2020

Conversation

craig-rueda
Copy link
Member

@craig-rueda craig-rueda commented Mar 11, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

We are currently running optimizations (CSS/JS) at build time of static assets. This is great for prod, but isn't necessary for local development stacks. This PR adds the option to skip optimizing when running in development mode.

  • Adding free memory nag
  • Running npm build with development options in compose

Tested with 2GB Docker Engine

image

@willbarrett

@craig-rueda craig-rueda changed the title Docker-Compose Memory Issue Docker-Compose Memory Issue Fix? Mar 11, 2020
@willbarrett
Copy link
Member

Nice. I was thinking about doing something like this after seeing the related issues on the repo. LGTM once the license check is fixed.

@craig-rueda craig-rueda merged commit e9b0095 into apache:master Mar 13, 2020
@craig-rueda craig-rueda deleted the docker_mem_tweaks branch March 13, 2020 16:25
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants