Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two typos in the README #9305

Merged
merged 1 commit into from Mar 14, 2020
Merged

Fixed two typos in the README #9305

merged 1 commit into from Mar 14, 2020

Conversation

mfharding
Copy link
Contributor

@mfharding mfharding commented Mar 14, 2020

I noticed two small typos in the README that I fixed:

  1. "Acts" was wrong because it does not have the correct subject-verb agreement
  2. "Who Have" is the wrong pronoun to use when referring to companies. "That have" is the grammatically correct option.
    Additionally, my company, Let's Roam, uses superset to visualize people completing challenges all over the world.

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

I noticed two small typos in the README that I fixed:
1) "Acts" was wrong because it does not have the correct subject-verb agreement
2) "Who Have" is the wrong pronoun to use when referring to companies. "That have" is the grammatically correct option. 
Additionally, my company, Let's Roam, uses superset to visualize people completing challenges all over the world.
@codecov-io
Copy link

Codecov Report

Merging #9305 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9305   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         374      374           
  Lines       12202    12202           
  Branches     2986     2986           
=======================================
  Hits         7209     7209           
  Misses       4814     4814           
  Partials      179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f40c8...72d8e95. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes and adding your org!

@villebro villebro merged commit b1916a1 into apache:master Mar 14, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants