Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra configuration to the email reports #9342

Merged
merged 1 commit into from May 13, 2020
Merged

Add extra configuration to the email reports #9342

merged 1 commit into from May 13, 2020

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Mar 21, 2020 •
edited

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

  1. Move EMAIL_PAGE_RENDER_WAIT to the config
  2. Introduce WEBDRIVER_BASEURL_USER_FRIENDLY for the links in the email for the usecases when WEBDRIVER_BASEURL is a localhost

TEST PLAN

[x] dropbox staging
[x] dropbox production

Reviewers

@bkyryliuk bkyryliuk changed the title CI: Add extra configration to the email reports Add extra configuration to the email reports Mar 21, 2020
@bogdan-dbx
Add extra configration to the email reports
95917e0 
Superset email. Fix slice url

Make WEBDRIVER_BASEURL a function
villebro
villebro approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 1d3b264 into apache:master May 13, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkyryliuk @villebro @mistercrunch @bogdan-dbx