Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move docs image symlink to _static #9592

Merged
merged 3 commits into from Apr 22, 2020

Conversation

villebro
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

#9098 introduced a regression in the documentation by placing the images symlink to frontend images in the root of docs, not docs/_static. This removes the old symlink and recreates the symlink in docs/_static.

SCREEHSHOTS

BEFORE

image

AFTER

image

TEST PLAN

ADDITIONAL INFORMATION

REVIEWERS

@codecov-io
Copy link

codecov-io commented Apr 20, 2020

Codecov Report

Merging #9592 into master will increase coverage by 4.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9592      +/-   ##
==========================================
+ Coverage   65.65%   70.48%   +4.83%     
==========================================
  Files         574      574              
  Lines       30131    30131              
  Branches     3066     3066              
==========================================
+ Hits        19782    21239    +1457     
+ Misses      10165     8781    -1384     
+ Partials      184      111      -73     
Flag Coverage Δ
#cypress 53.71% <ø> (?)
#javascript 58.76% <ø> (ø)
#python 70.50% <ø> (ø)
Impacted Files Coverage Δ
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 56.98% <0.00%> (+1.07%) ⬆️
superset-frontend/src/components/EditableTitle.jsx 81.69% <0.00%> (+1.40%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 81.35% <0.00%> (+1.69%) ⬆️
superset-frontend/src/utils/common.js 69.64% <0.00%> (+1.78%) ⬆️
...src/explore/components/controls/VizTypeControl.jsx 78.84% <0.00%> (+1.92%) ⬆️
...rset-frontend/src/explore/components/SaveModal.jsx 94.73% <0.00%> (+2.10%) ⬆️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 55.12% <0.00%> (+2.56%) ⬆️
...end/src/dashboard/components/dnd/DragDroppable.jsx 97.29% <0.00%> (+2.70%) ⬆️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbffed...2df10a2. Read the comment docs.

@villebro villebro force-pushed the villebro/fix-docs-img-symlink branch from 999682d to 4ed8c02 Compare April 21, 2020 18:36
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@villebro villebro force-pushed the villebro/fix-docs-img-symlink branch from edbd397 to 2df10a2 Compare April 22, 2020 06:02
@villebro villebro merged commit c3307fa into apache:master Apr 22, 2020
@villebro villebro deleted the villebro/fix-docs-img-symlink branch April 27, 2020 13:20
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All tutorial images are down static resource http 404 ,can't open
4 participants