Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] increase tab count limit #9640

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Apr 23, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Currently dashboard only allow up to 7 tabs in one tab container. This PR is to increase the limit to 10.

TEST PLAN

Manual test.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@etr2460 @williaster

@codecov-io
Copy link

codecov-io commented Apr 23, 2020

Codecov Report

Merging #9640 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9640      +/-   ##
==========================================
- Coverage   70.52%   70.31%   -0.22%     
==========================================
  Files         574      182     -392     
  Lines       30152    17700   -12452     
  Branches     3060        0    -3060     
==========================================
- Hits        21265    12445    -8820     
+ Misses       8776     5255    -3521     
+ Partials      111        0     -111     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 70.31% <ø> (-0.26%) ⬇️
Impacted Files Coverage Δ
superset/views/database/mixins.py 58.92% <0.00%> (-21.43%) ⬇️
superset/utils/cache.py 45.83% <0.00%> (-20.84%) ⬇️
superset/db_engine_specs/postgres.py 80.00% <0.00%> (-15.00%) ⬇️
superset/db_engine_specs/mysql.py 78.26% <0.00%> (-13.05%) ⬇️
superset/views/database/api.py 83.90% <0.00%> (-3.45%) ⬇️
superset/models/core.py 84.47% <0.00%> (-2.39%) ⬇️
superset/security/manager.py 88.77% <0.00%> (-0.35%) ⬇️
superset/views/core.py 75.01% <0.00%> (-0.23%) ⬇️
superset/connectors/sqla/models.py 88.37% <0.00%> (-0.16%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.js
... and 390 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6cedaa...a41ea96. Read the comment docs.

@etr2460
Copy link
Member

etr2460 commented Apr 24, 2020

We should probably make sure @mistercrunch @rusackas and @betodealmeida at least get pinged on this so they're aware of the design change.

If everyone's in agreement, then lgtm. otherwise we might consider a config var

@rusackas
Copy link
Member

The intent in the update for the tabs, as I recall, is to let them take up whatever width they need, and (much like Chrome's tabs) tack on a dropdown menu if they overflow the available real estate. In the light of that, I don't think tweaking the number of tabs for the current design should make much difference in the long run.

@rusackas
Copy link
Member

But thank you for pointing out this kind of thing, I sincerely appreciate it.

@graceguo-supercat graceguo-supercat merged commit 29dd989 into apache:master Apr 24, 2020
@graceguo-supercat graceguo-supercat deleted the gg-IncreaseTabCount branch June 11, 2020 23:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants