Preferring config[] over config.get #9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hope there's not a reason any of these need to be in the other syntax. Just figured changing them all would mean fewer people (myself included!) would copy the wrong pattern. |
Codecov Report
@@ Coverage Diff @@
## master #9676 +/- ##
==========================================
- Coverage 70.57% 70.56% -0.01%
==========================================
Files 581 581
Lines 30272 30272
Branches 3078 3078
==========================================
- Hits 21364 21361 -3
- Misses 8796 8799 +3
Partials 112 112
Continue to review full report at Codecov.
|
etr2460
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
validated that all these variables exist in the config.py file already. Thanks for the cleanup!
cc @john-bodley as he'll appreciate this too
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Favoring
config["WHATEVER"]overconfig.get("WHATEVER"). Pattern preference stated by, and commit summary message dedicated to, @etr2460.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@etr2460