Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security) Fixing regression in #9689 #9705

Merged
merged 1 commit into from Apr 30, 2020
Merged

fix(security) Fixing regression in #9689 #9705

merged 1 commit into from Apr 30, 2020

Conversation

john-bodley
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR fixes a regression introduced in #9689 where the caching was handling the presence of the rls key differently dependency on the context. This PR ensures that viz.py behaves like viz_sip38.py and the QueryContext where the key is present regardless if row-level-security is enabled.

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @bkyryliuk @villebro

@john-bodley john-bodley merged commit a908813 into apache:master Apr 30, 2020
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Apr 30, 2020
@john-bodley
fix(security) Fixing regression in apache#9689 (apache#9705)
066da2e 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit a908813)
@mistercrunch mistercrunch added the !deprecated-label:bug Deprecated label - Use #bug instead label Apr 30, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkyryliuk bkyryliuk bkyryliuk approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:bug Deprecated label - Use #bug instead size/XS 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-bodley @bkyryliuk @mistercrunch