Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate bignumber to use builtin controls #9707

Merged
merged 2 commits into from May 1, 2020

Conversation

suddjian
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

The BigNumber plugin has been updated to handle its own controls registration. This updates the plugin to the new version and removes the controls from incubator-superset.

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@rusackas @kristw @ktmud

@suddjian
Copy link
Member Author

I installed @babel/compat-data to fix errors that popped up when running dev-server, but I'm not sure why it's required. Might be a peer dependency somewhere. Anyway, it started working again once I installed it.

@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #9707 into master will increase coverage by 4.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9707      +/-   ##
==========================================
+ Coverage   65.90%   70.71%   +4.80%     
==========================================
  Files         586      584       -2     
  Lines       30383    30376       -7     
  Branches     3110     3109       -1     
==========================================
+ Hits        20025    21481    +1456     
+ Misses      10174     8781    -1393     
+ Partials      184      114      -70     
Flag Coverage Δ
#cypress 53.57% <ø> (?)
#javascript 58.89% <ø> (+0.03%) ⬆️
#python 70.88% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/setup/setupPlugins.ts 7.54% <ø> (+7.54%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 56.98% <0.00%> (+1.07%) ⬆️
superset-frontend/src/components/EditableTitle.jsx 81.69% <0.00%> (+1.40%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 81.35% <0.00%> (+1.69%) ⬆️
superset-frontend/src/utils/common.js 69.64% <0.00%> (+1.78%) ⬆️
...src/explore/components/controls/VizTypeControl.jsx 78.84% <0.00%> (+1.92%) ⬆️
...rset-frontend/src/explore/components/SaveModal.jsx 94.73% <0.00%> (+2.10%) ⬆️
superset-frontend/src/explore/controlUtils.js 96.80% <0.00%> (+2.12%) ⬆️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad8209...f38ae67. Read the comment docs.

@craig-rueda craig-rueda merged commit 9d3da79 into apache:master May 1, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants