[caching] Using request context rather than globals

[john-bodley]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

@villebro I was thinking some more about the cache warmup and the form-data problem, and for testing we were leveraging test_request_context which creates a RequestContext and I wondered if using that was cleaner than temporarily leveraging g.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Tested locally.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

to: @villebro

[john-bodley]

@villebro what are your thoughts regarding this approach?

[villebro]

I think this is a cleaner approach. Would be nice if there was a linter that made it possible to blacklist flask.g and others we want to avoid in the future (or is there one?)

[john-bodley]

@villebro there are times we want to use flask.g, i.e., for storing the current user so I don't think it's a pattern we always wish to strictly avoid.