chore: update README screenshots #9728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etr2460 thanks for taking the time. LGTM. Can be viewed here https://github.com/etr2460/incubator-superset/tree/erik-ritter--update-screenshots We're looking to update the screenshots further soon, throwing in a high quality animated gif, and finding some ways to get more density with tiles. |
mistercrunch
approved these changes
May 5, 2020
|
That's not actually where they can be viewed because the README pulls from the master images. But i'll see it in master after merging now anyway |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The current screenshots are rather out of date, I've updated the first 3 but couldn't update the other 2 because the deck.gl charts don't render properly for me. Maybe someone else could pick that up for me?
TEST PLAN
CI
ADDITIONAL INFORMATION
REVIEWERS
to: @mistercrunch