Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-add all time grain options to the new chart API #9744

Merged
merged 1 commit into from May 6, 2020
Merged

fix: re-add all time grain options to the new chart API #9744

merged 1 commit into from May 6, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented May 5, 2020 •
edited

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

The new chart API doesn't support all the time grains db_engine_specs supports, adding the missing granularities here

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @villebro @john-bodley @craig-rueda @dpgaspar

williaster
williaster approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @etr2460 ! 🙏

@etr2460 etr2460 merged commit eee6280 into master May 6, 2020
@etr2460 etr2460 deleted the etr2460--time-grain-options branch July 1, 2020 15:14
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etr2460 @williaster @john-bodley @mistercrunch