Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add SSL config options for postgres #9767

Merged
merged 2 commits into from May 10, 2020
Merged

[docs] Add SSL config options for postgres #9767

merged 2 commits into from May 10, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented May 7, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Add some SSL documentation to PG docs

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@craig-rueda

@nytai nytai changed the title Tai/add pg connection docs 2 [docs] Add SSL config options for postgres May 7, 2020
@nytai nytai force-pushed the tai/add-pg-connection-docs-2 branch from 8dbc9ee to ead2d38 Compare May 7, 2020 22:11
@nytai nytai closed this May 7, 2020
@nytai nytai reopened this May 7, 2020
@nytai
Copy link
Member Author

nytai commented May 7, 2020

😠 fossa

@codecov-io
Copy link

codecov-io commented May 7, 2020 •
edited

Codecov Report

Merging #9767 into master will decrease coverage by 4.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9767      +/-   ##
==========================================
- Coverage   70.93%   65.99%   -4.95%     
==========================================
  Files         183      587     +404     
  Lines       17847    30460   +12613     
  Branches        0     3121    +3121     
==========================================
+ Hits        12660    20101    +7441     
- Misses       5187    10175    +4988     
- Partials        0      184     +184
Flag Coverage Δ
#javascript 59.00% <ø> (?)
#python 70.92% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
superset/models/core.py 86.13% <0.00%> (-0.73%) ⬇️
...src/explore/components/controls/SpatialControl.jsx 6.66% <0.00%> (ø)
...perset-frontend/src/dashboard/util/findParentId.js 100.00% <0.00%> (ø)
superset-frontend/src/visualizations/constants.js 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
superset-frontend/src/components/TableSelector.jsx 78.35% <0.00%> (ø)
...d/src/visualizations/TimeTable/FormattedNumber.jsx 0.00% <0.00%> (ø)
superset-frontend/src/components/Menu/Menu.jsx 87.50% <0.00%> (ø)
...uperset-frontend/src/utils/getClientErrorObject.ts 82.14% <0.00%> (ø)
superset-frontend/src/modules/dates.js 100.00% <0.00%> (ø)
... and 395 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c5b13...fa01c22. Read the comment docs.

@nytai nytai closed this May 8, 2020
@nytai nytai reopened this May 8, 2020
@nytai nytai force-pushed the tai/add-pg-connection-docs-2 branch from ac127a9 to 93e754e Compare May 8, 2020 05:41
@pull-request-size pull-request-size bot added size/L and removed size/S labels May 8, 2020
dpgaspar
dpgaspar approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of nit's

docs/installation.rst
See `psycopg2 SQLAlchemy <https://docs.sqlalchemy.org/en/13/dialects/postgresql.html#module-sqlalchemy.dialects.postgresql.psycopg2>`_.
Additional may be configured via the ``extra`` field under ``engine_params``.
If you would like to enable mutual SSL here is a sample configuration: ::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. code-block:: json

docs/installation.rst

If you would like to enable mutual SSL here is a sample configuration: ::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. code-block:: json

@nytai nytai force-pushed the tai/add-pg-connection-docs-2 branch from 52f671f to fa01c22 Compare May 8, 2020 21:47
@nytai nytai requested a review from dpgaspar May 9, 2020 20:39
@dpgaspar dpgaspar merged commit 24db9ab into apache:master May 10, 2020
@dpgaspar dpgaspar deleted the tai/add-pg-connection-docs-2 branch May 10, 2020 18:37
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nytai @codecov-io @craig-rueda @dpgaspar @mistercrunch