Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix, script to help run single tests #9779

Merged
merged 2 commits into from May 11, 2020

Conversation

dpgaspar
Copy link
Member

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

If the developer did not have an already test database created the script would just fail

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #9779 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9779      +/-   ##
==========================================
- Coverage   70.78%   70.77%   -0.01%     
==========================================
  Files         587      587              
  Lines       30460    30460              
  Branches     3121     3121              
==========================================
- Hits        21561    21558       -3     
- Misses       8785     8788       +3     
  Partials      114      114              
Flag Coverage Δ
#cypress 53.66% <ø> (-0.08%) ⬇️
#javascript 59.00% <ø> (ø)
#python 70.93% <ø> (ø)
Impacted Files Coverage Δ
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <0.00%> (-6.82%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 66.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b10ae...b66990f. Read the comment docs.

scripts/tests/run.sh Outdated Show resolved Hide resolved
@dpgaspar dpgaspar requested a review from villebro May 11, 2020 15:40
@dpgaspar dpgaspar merged commit 660ea88 into apache:master May 11, 2020
@dpgaspar dpgaspar deleted the fix/tests-script branch May 11, 2020 16:42
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants