build: disable webpack progress for CI #9791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
reviewed
May 12, 2020
| @@ -12,12 +12,12 @@ | |||
| "test": "NODE_ENV=test jest", | |||
| "type": "tsc --noEmit", | |||
| "cover": "NODE_ENV=test jest --coverage", | |||
| "dev": "webpack --mode=development --colors --progress --debug --watch", | |||
| "dev-server": "NODE_ENV=development BABEL_ENV=development node --max_old_space_size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=development --progress", | |||
There was a problem hiding this comment.
I don't mind it on dev and dev-server as it's something to watch, and helps me gauge when I should see the view refresh.
There was a problem hiding this comment.
They will continue to report progress, as long as the environment variable CI is not set——which should be the case for most If not all users. This change is just for consistency’s sake.
rusackas
approved these changes
May 12, 2020
kristw
approved these changes
May 12, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This disables webpack progress report for CI environment.
Webpack progress report generates excessive logs for the CI, making it difficult to find useful information.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After: there should be no such excessive logs.
TEST PLAN
Make sure webpack progress report still show up in local dev environment, but not in CI (where CI=true is set for most CI tools).
ADDITIONAL INFORMATION
N/A