fix: construct SupersetErrors properly

[etr2460]

SUMMARY

I'm shocked mypy didn't catch this, but here ya go...

SupersetError should be initialized with an error_type, not a type

TEST PLAN

CI

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

to: @john-bodley @michellethomas @villebro

[codecov-io]

Codecov Report

Merging #9799 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9799      +/-   ##
==========================================
- Coverage   70.84%   70.61%   -0.24%     
==========================================
  Files         588      588              
  Lines       30472    30472              
  Branches     3153     3153              
==========================================
- Hits        21589    21518      -71     
- Misses       8769     8834      +65     
- Partials      114      120       +6     

Flag	Coverage Δ
#cypress	52.90% <ø> (-0.73%)	⬇️
#javascript	59.02% <ø> (ø)
#python	70.99% <ø> (-0.07%)	⬇️

Impacted Files	Coverage Δ
superset/viz.py	72.00% <ø> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js	33.33% <0.00%> (-16.67%)	⬇️
superset/db_engine_specs/mysql.py	78.26% <0.00%> (-13.05%)	⬇️
superset-frontend/src/reduxUtils.js	76.47% <0.00%> (-10.30%)	⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx	75.52% <0.00%> (-6.30%)	⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js	61.13% <0.00%> (-5.03%)	⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx	44.00% <0.00%> (-4.00%)	⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js	37.44% <0.00%> (-3.30%)	⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx	88.57% <0.00%> (-2.86%)	⬇️
superset-frontend/src/components/TableSelector.jsx	81.34% <0.00%> (-2.24%)	⬇️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c8fcf...a90102c. Read the comment docs.

[john-bodley]

@etr2460 mypy type checking isn't yet enforced for all modules per here. That may have been the reason.

[etr2460]

So I can add superset.errors to that list and i should get type checking?

[john-bodley]

@etr2460 you would need to add superset.viz et al. (as opposed to superset.errors) to the list in order to invoke the following error,

superset/viz.py:467: error: Unexpected keyword argument "type" for "SupersetError"

That said there is no harm in adding modules which are completely typed.