refactor: simplify getExploreUrl functions #9831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
May 18, 2020
Comment on lines
-126
to
-139
| expect(payload).toEqual(formData); | ||
| }); | ||
| it('generate proper saveas slice url', () => { | ||
| const { url, payload } = getExploreUrlAndPayload({ | ||
| formData, | ||
| endpointType: 'json', | ||
| force: false, | ||
| curUrl: 'superset.com?foo=bar', | ||
| }); | ||
| compareURI( | ||
| URI(url), | ||
| URI('/superset/explore_json/').search({ foo: 'bar' }), | ||
| ); | ||
| expect(payload).toEqual(formData); |
There was a problem hiding this comment.
This was an identical copy of the test case above.
Codecov Report
@@ Coverage Diff @@
## master #9831 +/- ##
==========================================
- Coverage 71.02% 70.79% -0.24%
==========================================
Files 586 184 -402
Lines 30635 17868 -12767
Branches 3151 0 -3151
==========================================
- Hits 21759 12649 -9110
+ Misses 8765 5219 -3546
+ Partials 111 0 -111
Continue to review full report at Codecov.
|
villebro
changed the title
villebro
force-pushed
the
villebro/refactor-get-explore-uri
branch
from
eeafad4
to
a53d7ec
Compare
villebro
force-pushed
the
villebro/refactor-get-explore-uri
branch
from
a53d7ec
to
4e02f4e
Compare
villebro
changed the title
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* remove payload from return signature * Rename function and fix tests * Lint * fix tests * Move useLegacyApi inquiry to exploreUtils
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
getExploreUrlAndPayloadfunction is currently unnecessarily complex and returns an unmutated copy of one of its inputs (formData). Also, thegetURIDirectorysignature includedformDatawhich was never used. This PR simplifies the function signatures with the ultimate aim of breaking up the functions into smaller more specific functions.TEST PLAN
Local testing + CI
ADDITIONAL INFORMATION