fix: Removing the logic to add timeseries_limit_metric to the data for table #9832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
changed the title
michellethomas
changed the title
john-bodley
reviewed
May 18, 2020
ktmud
approved these changes
May 19, 2020
|
@john-bodley the unit test that's there should prevent the time series table column from showing up in the data that gets returned, it was just written originally to return it because that was needed for the frontend. I think this should have an integration test to make sure that when there's a metric and a sortby on a table, only the metric column shows up, that would have caught this bug when the table viz changed. When I looked into this, I noticed that the visualization integration tests were not actually running. Are you ok if I add the test in a separate PR after the visualization tests are turned back on? |
john-bodley
approved these changes
May 20, 2020
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 20, 2020
…r table (apache#9832) * Removing the logic to add timeseries_limit_metric to the data for table viz * Also make the change in viz_sip_38 * Fix tests Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com> (cherry picked from commit 368c85d)
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…r table (apache#9832) * Removing the logic to add timeseries_limit_metric to the data for table viz * Also make the change in viz_sip_38 * Fix tests Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removing logic to add the timeseries_limit_metric to data for Table viz. This was previously necessary in the old Table viz to fix a bug where labeled metrics with a sortby wouldn't show up. This is no longer necessary in the new Table viz and causes an extra column to show up on the table.
TEST PLAN
Testing table viz with and without sortby, with and without labeled metrics.
ADDITIONAL INFORMATION
@john-bodley @etr2460 @ktmud