Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade plugins, remove unnecessary code #9848

Merged
merged 1 commit into from May 20, 2020

Conversation

suddjian
Copy link
Member

SUMMARY

These plugins now manage their own control panels.

TEST PLAN

Tested each plugin locally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@suddjian suddjian changed the title upgrade plugins, remove unnecessary code chore: upgrade plugins, remove unnecessary code May 19, 2020
@suddjian suddjian closed this May 19, 2020
@suddjian suddjian reopened this May 19, 2020
@suddjian suddjian changed the title chore: upgrade plugins, remove unnecessary code refactor: upgrade plugins, remove unnecessary code May 19, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #9848 into master will increase coverage by 4.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9848      +/-   ##
==========================================
+ Coverage   66.32%   71.17%   +4.84%     
==========================================
  Files         588      584       -4     
  Lines       30786    30771      -15     
  Branches     3238     3238              
==========================================
+ Hits        20418    21900    +1482     
+ Misses      10181     8759    -1422     
+ Partials      187      112      -75     
Flag Coverage Δ
#cypress 54.04% <ø> (?)
#javascript 59.37% <ø> (+0.06%) ⬆️
#python 71.27% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/setup/setupPlugins.ts 16.66% <ø> (+16.66%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 56.98% <0.00%> (+1.07%) ⬆️
superset-frontend/src/components/EditableTitle.jsx 81.69% <0.00%> (+1.40%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 81.35% <0.00%> (+1.69%) ⬆️
superset-frontend/src/utils/common.js 69.64% <0.00%> (+1.78%) ⬆️
...src/explore/components/controls/VizTypeControl.jsx 78.84% <0.00%> (+1.92%) ⬆️
superset-frontend/src/explore/controlUtils.js 96.93% <0.00%> (+2.04%) ⬆️
...rset-frontend/src/explore/components/SaveModal.jsx 93.54% <0.00%> (+2.15%) ⬆️
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368c85d...5045922. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍻

@rusackas rusackas merged commit f076485 into apache:master May 20, 2020
@suddjian suddjian deleted the controls-update-2 branch May 20, 2020 19:41
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants