fix: raise error in sqllab when using reserved column name

[villebro]

SUMMARY

Currently SQL Lab accepts the column name __timestamp, which causes problems when pressing the "Explore" button. This usually happens when clicking the "Run in SQL Lab" button on a timeseries chart. This adds a check for column names starting with double underscores.

BEFORE

AFTER

TEST PLAN

Local testing + new tests

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[eugeniamz]

It is a good fix to improve the error message but CHARTs generate the query with reserved words so if the workflow is

Chart -> SQL Lab : you get the reserved word and needs to be changed if you want to Explore the data again.

If in CHARTs we don't generate reserved words, that should resolve the issue to the root.

[codecov-commenter]

Codecov Report

Merging #9859 into master will increase coverage by 6.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9859      +/-   ##
==========================================
+ Coverage   64.61%   71.13%   +6.51%     
==========================================
  Files         536      588      +52     
  Lines       29405    30793    +1388     
  Branches     2879     3238     +359     
==========================================
+ Hits        19001    21904    +2903     
+ Misses      10225     8778    -1447     
+ Partials      179      111      -68     

Flag	Coverage Δ
#cypress	53.95% <0.00%> (-0.09%)	⬇️
#javascript	59.30% <100.00%> (?)
#python	71.27% <ø> (ø)

Impacted Files	Coverage Δ
...end/src/SqlLab/components/ExploreResultsButton.jsx	74.07% <100.00%> (+69.07%)	⬆️
superset-frontend/src/setup/setupPlugins.ts	13.33% <0.00%> (-86.67%)	⬇️
...rset-frontend/src/setup/setupErrorMessagesExtra.ts	50.00% <0.00%> (-50.00%)	⬇️
superset-frontend/src/setup/setupErrorMessages.ts	66.66% <0.00%> (-33.34%)	⬇️
.../src/components/Select/WindowedSelect/windowed.tsx	94.11% <0.00%> (-5.89%)	⬇️
superset-frontend/src/setup/setupApp.ts	25.00% <0.00%> (-3.58%)	⬇️
superset-frontend/src/featureFlags.ts	100.00% <0.00%> (ø)
superset-frontend/src/components/styles.ts	100.00% <0.00%> (ø)
superset-frontend/src/SqlLab/utils/sqlKeywords.ts	100.00% <0.00%> (ø)
...et-frontend/src/dashboard/util/isDashboardEmpty.ts	100.00% <0.00%> (ø)
... and 192 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a775e2...75e9615. Read the comment docs.

[villebro]

@eugeniamz the thing here is that the query as such is not really usable for re-exploration, as it has time grains, filters etc burned into the query. My interpretation is that this feature is used for throwaway analysis purposes only. Perhaps we should also add a comment above the query to that effect to explain that the query is only a reflection of a certain chart, and should usually not be used as a basis for a new chart?

[eugeniamz]

I understand that this the best solution for now, at list this will avoid the back and forward. Thanks Ville!