Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't create examples db on 'superset init' #9881

Merged
merged 2 commits into from May 22, 2020

Conversation

mistercrunch
Copy link
Member

SUMMARY

superset init should not create the examples database as it does now

closes #9879

@mistercrunch mistercrunch changed the title chore: don't create examples db on 'superset init' fix: don't create examples db on 'superset init' May 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #9881 into master will decrease coverage by 0.14%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9881      +/-   ##
==========================================
- Coverage   71.24%   71.10%   -0.15%     
==========================================
  Files         584      584              
  Lines       30790    30606     -184     
  Branches     3238     3142      -96     
==========================================
- Hits        21936    21761     -175     
+ Misses       8744     8736       -8     
+ Partials      110      109       -1     
Flag Coverage Δ
#cypress 53.83% <ø> (ø)
#javascript 59.44% <ø> (ø)
#python 71.14% <83.33%> (-0.25%) ⬇️
Impacted Files Coverage Δ
superset/cli.py 36.72% <ø> (-3.00%) ⬇️
superset/viz_sip38.py 0.00% <0.00%> (ø)
superset/db_engine_specs/base.py 87.20% <100.00%> (ø)
superset/errors.py 100.00% <100.00%> (ø)
superset/sql_parse.py 99.29% <100.00%> (-0.01%) ⬇️
superset/views/base.py 73.21% <100.00%> (-0.24%) ⬇️
superset/viz.py 71.85% <100.00%> (-0.12%) ⬇️
superset/views/tags.py 35.13% <0.00%> (-4.11%) ⬇️
superset/models/sql_types/presto_sql_types.py 72.41% <0.00%> (-4.06%) ⬇️
superset/models/tags.py 58.58% <0.00%> (-3.80%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8e441...217178f. Read the comment docs.

@mistercrunch
Copy link
Member Author

mistercrunch commented May 22, 2020

Looks like isort is having some confusion around py3.6 and py3.7 (?)

I'm 3.7 locally somehow, but CI is 3.6 and passes...

@mistercrunch mistercrunch merged commit ee99196 into apache:master May 22, 2020
@mistercrunch mistercrunch deleted the no_example_db branch May 22, 2020 04:34
pkdotson pushed a commit to preset-io/superset that referenced this pull request May 26, 2020
* chore: don't create examples db on 'superset init'

* fix isort
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* chore: don't create examples db on 'superset init'

* fix isort
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't create examples sqlite datasource
3 participants