Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing line break in Database 'extra' instructions #9895

Merged
merged 2 commits into from May 24, 2020

Conversation

tooptoop4
Copy link
Contributor

Fixes #9868

point 3 runs on to point 4

@tooptoop4 tooptoop4 changed the title Add missing line break in Database 'extra' instructions fix: Add missing line break in Database 'extra' instructions May 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #9895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9895   +/-   ##
=======================================
  Coverage   71.25%   71.25%           
=======================================
  Files         584      584           
  Lines       30809    30809           
  Branches     3238     3238           
=======================================
  Hits        21953    21953           
  Misses       8746     8746           
  Partials      110      110           
Flag Coverage Δ
#cypress 53.84% <ø> (ø)
#javascript 59.44% <ø> (ø)
#python 71.40% <ø> (ø)
Impacted Files Coverage Δ
superset/views/database/mixins.py 80.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e789a35...bb0a6c2. Read the comment docs.

@mistercrunch mistercrunch merged commit bd95991 into apache:master May 24, 2020
pkdotson pushed a commit to preset-io/superset that referenced this pull request May 26, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'extra' section in new datasource screen missing linebreak
3 participants