Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: paired t testchart control migration #9916

Conversation

pkdotson
Copy link
Member

SUMMARY

remove controls and shims from superset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #9916 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9916   +/-   ##
=======================================
  Coverage   71.22%   71.23%           
=======================================
  Files         585      585           
  Lines       30869    30868    -1     
  Branches     3239     3239           
=======================================
+ Hits        21987    21989    +2     
+ Misses       8772     8770    -2     
+ Partials      110      109    -1     
Flag Coverage Δ
#cypress 53.82% <ø> (+0.01%) ⬆️
#javascript 59.41% <ø> (+<0.01%) ⬆️
#python 71.40% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/setup/setupPlugins.ts 19.04% <ø> (+0.86%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 86.51% <0.00%> (-1.13%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 66.81% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fffa37...c282cb0. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e0c3da5 into apache:master May 26, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants