style(mypy): Enforcing typing for views.database #9920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
May 26, 2020
superset/views/database/filters.py
Outdated
| self, query, func | ||
| ): # noqa pylint: disable=unused-argument,arguments-differ | ||
| def apply( # noqa pylint: disable=unused-argument | ||
| self, query: Query, value: Optional[Any] |
There was a problem hiding this comment.
I renamed func to value for consistency with the base class.
| self._pre_add_update(database) | ||
|
|
||
| def pre_delete(self, obj): # pylint: disable=no-self-use | ||
| if obj.tables: | ||
| def pre_delete(self, database: Database) -> None: # pylint: disable=no-self-use |
There was a problem hiding this comment.
I renamed obj to database for consistency.
Codecov Report
@@ Coverage Diff @@
## master #9920 +/- ##
=======================================
Coverage 71.31% 71.32%
=======================================
Files 585 585
Lines 30874 30876 +2
Branches 3236 3236
=======================================
+ Hits 22019 22023 +4
+ Misses 8746 8744 -2
Partials 109 109
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
May 27, 2020
john-bodley
force-pushed
the
john-bodley--mypy-enforcement-views-database
branch
from
28b8e5f
to
529566d
Compare
john-bodley
force-pushed
the
john-bodley--mypy-enforcement-views-database
branch
from
529566d
to
b6b2ed3
Compare
john-bodley
commented
May 28, 2020
| @expose( | ||
| "/<int:pk>/table/<string:table_name>/<string:schema_name>/", methods=["GET"] | ||
| ) | ||
| @expose("/<int:pk>/table/<table_name>/<schema_name>/", methods=["GET"]) |
There was a problem hiding this comment.
Note per here string is the default converter type and thus doesn't need to be explicitly defined. This is consistent with other views.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding
mypytype enforcement for thesuperset.views.databasemodule. Note because thesuperset.viewsmodule is quite large I opted to break the type enforcement into smaller more digestible chunks.TEST PLAN
CI.
ADDITIONAL INFORMATION