Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mypy): Resolves regression introducted in #9824 #9973

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR fixes a regression introduced in #9824 and additional makes from_dttm/to_dttm optional (unrelated to the regression PR).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI and confirmed the change locally.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @serenajiang

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #9973 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9973   +/-   ##
=======================================
  Coverage   71.35%   71.36%           
=======================================
  Files         585      585           
  Lines       30917    30917           
  Branches     3246     3246           
=======================================
+ Hits        22061    22064    +3     
+ Misses       8747     8744    -3     
  Partials      109      109           
Flag Coverage Δ
#cypress 54.00% <ø> (-0.08%) ⬇️
#javascript 59.39% <ø> (ø)
#python 71.54% <100.00%> (+0.03%) ⬆️
Impacted Files Coverage Δ
superset/connectors/sqla/models.py 90.51% <ø> (ø)
superset/common/query_object.py 89.42% <100.00%> (ø)
superset/tasks/cache.py 73.91% <100.00%> (ø)
superset/utils/core.py 89.18% <100.00%> (ø)
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <0.00%> (-6.82%) ⬇️
superset/sql_lab.py 78.26% <0.00%> (+0.43%) ⬆️
superset/result_set.py 98.31% <0.00%> (+1.68%) ⬆️
superset/db_engine_specs/sqlite.py 73.33% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1001c6d...1a32f35. Read the comment docs.

@john-bodley john-bodley merged commit ee777ac into apache:master Jun 3, 2020
@john-bodley john-bodley deleted the john-bodley--fix-9824-regression branch June 3, 2020 07:20
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants