Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove markup and separator from viz.py #9997

Merged
merged 1 commit into from Jun 10, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 5, 2020

SUMMARY

The markup and separator viz shims are no longer needed in viz.py.

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #9997 into master will increase coverage by 4.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9997      +/-   ##
==========================================
+ Coverage   65.58%   70.43%   +4.85%     
==========================================
  Files         585      585              
  Lines       31020    30986      -34     
  Branches     3277     3277              
==========================================
+ Hits        20345    21826    +1481     
+ Misses      10494     9048    -1446     
+ Partials      181      112      -69     
Flag Coverage Δ
#cypress 53.90% <ø> (?)
#javascript 59.37% <ø> (ø)
#python 70.05% <ø> (+0.07%) ⬆️
Impacted Files Coverage Δ
superset/viz.py 57.13% <ø> (-0.02%) ⬇️
superset/viz_sip38.py 0.00% <ø> (ø)
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 56.98% <0.00%> (+1.07%) ⬆️
superset-frontend/src/components/EditableTitle.jsx 81.69% <0.00%> (+1.40%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 81.35% <0.00%> (+1.69%) ⬆️
superset-frontend/src/utils/common.js 69.64% <0.00%> (+1.78%) ⬆️
...src/explore/components/controls/VizTypeControl.jsx 78.84% <0.00%> (+1.92%) ⬆️
superset-frontend/src/explore/controlUtils.js 96.90% <0.00%> (+2.06%) ⬆️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4d4f1...3812d40. Read the comment docs.

@villebro villebro merged commit 7cb38fe into apache:master Jun 10, 2020
@villebro villebro deleted the villebro/remove-markup branch September 1, 2020 10:15
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants