Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSTEMML-485] Rename unusual file extensions #418

Conversation

deroneriksson
Copy link
Member

Rename unusual file extensions (.Rt -> .R, .dmlt -> .dml, .data -> .csv, etc.) to help standardize file naming in project.

@mboehm7
Copy link
Contributor

mboehm7 commented Mar 7, 2017

Could you please delete the L2SVM files? The dmlt and Rt extensions are generally used to indicate temporary files - for algorithm testcases, we do not generate them, so this must be a relict from a long time ago.

That reminds me, down the road, we should remove the entire "old codepath" from our testsuite. There are still various tests that use something like $$op1$$ + $$op2$$, replace these with input arguments, write the temporary dmlt script, and finally execute the script. This stems from a time when we did not have any input arguments (>5 years). Maybe we find a good way to automatically replace these tests.

Rename unusual file extensions to help standardize file naming in project.
@deroneriksson deroneriksson force-pushed the SYSTEMML-485-rename_unusual_file_extensions branch from 0c37b2b to 4c560aa Compare March 7, 2017 18:42
@deroneriksson
Copy link
Member Author

Sounds good. I deleted the L2SVMTest.Rt and L2SVMTest.dmlt and also added a needed update to WriteCSVTest.dml.

@mboehm7
Copy link
Contributor

mboehm7 commented Mar 8, 2017

LGTM - thanks @deroneriksson

@asfgit asfgit closed this in 6096494 Mar 8, 2017
j143-zz pushed a commit to j143-zz/systemml that referenced this pull request Nov 4, 2017
Rename unusual file extensions to help standardize file naming in project.

Closes apache#418.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants