This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-2611] TMUDF with input parameters returns wrong answer #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error in internal SQL issued by CLEANUP caused a piece of memory to be deallocated twice, resulting in an assertion failure.
When a TMUDF had a query with an input parameter or a CURRENT_TIMESTAMP (or CURRENT_DATE, CURRENT_TIME) in it, we sometimes return incorrect values. The problem was that these values were not set up correctly in the dataflow and they were not shipped as characteristic inputs to the operators that were referring to them.
The problem is that the new TINYINT type sometimes is stored in 1 byte, other times in 2 bytes. The TMUDF code makes the assumption that we can compute the storage size from the precision. The fix is in the binder and makes sure the storage size matches the storage size that the TMUDF code will compute.
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1794/ |
DaveBirdsall
approved these changes
May 11, 2017
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1794/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes for two more JIRAs:
[TRAFODION-2612] Internal error in CLEANUP in rare cases
[TRAFODION-2615] TMUDF returns wrong results with small numeric inputs
These three fixes are independent, so I would recommend reviewing each of the three commits separately.