This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-2646]mxosrvr change to AVAILABLE after timeout if no clien… #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1851/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1851/ |
|
|
||
| currDialogueId = atoi(tkn); | ||
| prevDialogueId = currDialogueId; | ||
|
|
There was a problem hiding this comment.
Sorry for the delay Weiqing.
We don't seem to be using prevDialogueId now ? Earlier this was introduced for problems seen in doing multiple connects/disconnects via endurance test. If similar tests have been run to test this change then please go ahead and merge.
https://issues.apache.org/jira/browse/TRAFODION-156
There was a problem hiding this comment.
I have run the all phx test. It haven't reproduced. And I also keep the logic as the old. So I think it's OK.
There was a problem hiding this comment.
Thanks for confirming. +1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t connect