[TRAFODION-2665] Update Character String Data Types #1137
Conversation
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1871/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1871/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this and also for getting rid of the visible underscores in the document.
+ | ||
specifies a column with varying-length character data. VARCHAR is | ||
equivalent to data type CHAR[ACTER] VARYING. | ||
|
||
* `NCHAR [(_length_)] [UPSHIFT] [[NOT]CASESPECIFIC], NATIONAL CHAR[ACTER] [(_length_)] [UPSHIFT] [[NOT]CASESPECIFIC]` | ||
+ | ||
specifies a column with data in the predefined national character set. | ||
specifies a column with data in the predefined national character set(USC2). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say (UCS2). Maybe also add a space between "set" and (UCS2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hans. I've incorporated your comment. :)
|
||
* `NCHAR VARYING [(_length_)] [UPSHIFT] [[NOT]CASESPECIFIC], NATIONAL CHAR[ACTER] VARYING (_length_) [UPSHIFT] [[NOT]CASESPECIFIC]` | ||
+ | ||
specifies a column with varying-length data in the predefined national character set. | ||
specifies a column with varying-length data in the predefined national character set(USC2). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hans. I've incorporated your comment. :)
* `_unit_` | ||
+ | ||
is an optional unit of either CHAR[ACTER[S]] or BYTE[S]. This unit is meaningful only for UTF8 characters. | ||
A UTF8 character is one to four bytes in length, therefore the storage length of a CHAR column that can hold _n_ UTF8 characters is 4*_n_ bytes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my mistake, this does not mention what the default unit is. Could we add something like: The default unit is CHARACTERS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hans. I've incorporated your comment. :)
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1880/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1880/ |
+1 |
Changes proposed in this pull request:
unit
andchar-set-name
.