[TRAFODION-2654] Change the location of trafodion-site.xml from $TRAF_HOME/etc to config #1143
Conversation
…_HOME/etc to config [TRAFODION-2653] Sort operator loops at times All HBase client connections from Trafodion uses Trafodion configuration concept. Any client side property can now be set in trafodion-site.xml. The scratch files are now open in blocking mode. Hence any scratch file operation shouldn't return EAGAIN. The internal table TDDL of table is now created without any table coprocessors attached to it.
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1879/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1879/ |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1883/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1883/ |
Previous Test Aborted. New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1884/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1884/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good to me (with the caveat that I probably don't understand the details well enough).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
wale.fillInStackTrace(); | ||
LOG.error("commitRequest txId: " + transactionId + " HLog seq " + txid + " Caught IOException in HLOG sync ", wale ); | ||
try { | ||
Thread.sleep(1000); ///1000 milliseconds is one second. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why thread.sleep if IO exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to stagger the sync operation assuming that it is colliding with another thread doing sync. It was thought that was the cause for concurrentModificationException at the time of sync. But @shangshengtung came up with different change that took care of concurrentModificationException. He will be delivering his change in a separate PR soon
[TRAFODION-2653] Sort operator loops at times
All HBase client connections from Trafodion uses Trafodion configuration concept. Any client side property can now be set in trafodion-site.xml.
The scratch files are now open in blocking mode. Hence any scratch file operation shouldn't return EAGAIN.
The internal table TDDL of table is now created without any table co-processors attached to it
The WAL sync can now be synchronized if needed to avoid DWE