Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-2654] Change the location of trafodion-site.xml from $TRAF_HOME/etc to config #1143

Merged
merged 5 commits into from Jun 26, 2017

Conversation

selvaganesang
Copy link
Contributor

@selvaganesang selvaganesang commented Jun 23, 2017

[TRAFODION-2653] Sort operator loops at times

All HBase client connections from Trafodion uses Trafodion configuration concept. Any client side property can now be set in trafodion-site.xml.

The scratch files are now open in blocking mode. Hence any scratch file operation shouldn't return EAGAIN.

The internal table TDDL of table is now created without any table co-processors attached to it

The WAL sync can now be synchronized if needed to avoid DWE

selvaganesang added 3 commits June 23, 2017 00:49
…_HOME/etc to config

[TRAFODION-2653] Sort operator loops at times

All HBase client connections from Trafodion uses Trafodion configuration
concept. Any client side property can now be set in trafodion-site.xml.

The scratch files are now open in blocking mode. Hence any scratch file
operation shouldn't return EAGAIN.

The internal table TDDL of table is now created without any table
coprocessors attached to it.
@selvaganesang selvaganesang changed the title [TRAFODION-2654] Change the location of trafodion-site.xml from $TRAF\_HOME/etc to config [TRAFODION-2654] Change the location of trafodion-site.xml from $TRAF_HOME/etc to config Jun 23, 2017
@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1879/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1883/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

Previous Test Aborted. New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1884/

@Traf-Jenkins
Copy link

Copy link
Contributor

@zellerh zellerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good to me (with the caveat that I probably don't understand the details well enough).

@asfgit asfgit merged commit 21c5e5e into apache:master Jun 26, 2017
Copy link
Contributor

@prashanth-vasudev prashanth-vasudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

wale.fillInStackTrace();
LOG.error("commitRequest txId: " + transactionId + " HLog seq " + txid + " Caught IOException in HLOG sync ", wale );
try {
Thread.sleep(1000); ///1000 milliseconds is one second.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why thread.sleep if IO exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to stagger the sync operation assuming that it is colliding with another thread doing sync. It was thought that was the cause for concurrentModificationException at the time of sync. But @shangshengtung came up with different change that took care of concurrentModificationException. He will be delivering his change in a separate PR soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants