This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
Fix for udr/TEST001 test failure #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My earlier change for TRAFODION-2637 (PR #1141) caused a non-deterministic failure of test udr/TEST001 and probably also TEST002. I added code that enables more parallel execution for TMUDFs. The tests have SELECT statements for these UDFs in them. Normally, the logsort program sorts the output of these queries, so random differences caused by parallel queries are ignored. However, some UDF query have the keywords ORDER BY in them, not for the main query, but for the inner query that is the child of the UDF. That suppressed sorting and caused a difference. The fix is to add an ORDER BY for the main query when we could expect a non-deterministic order and when the child query of the UDF uses ORDER BY. Dave suggested that we could also change the logsort program to recognize different types of ORDER BY, but this is probably not needed right now.
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1895/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1895/ |
DaveBirdsall
approved these changes
Jun 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My earlier change for TRAFODION-2637 (PR #1141) caused a
non-deterministic failure of test udr/TEST001 and probably also
TEST002.
I added code that enables more parallel execution for TMUDFs. The
tests have SELECT statements for these UDFs in them. Normally, the
logsort program sorts the output of these queries, so random
differences caused by parallel queries are ignored. However, some UDF
query have the keywords ORDER BY in them, not for the main query, but
for the inner query that is the child of the UDF. That suppressed
sorting and caused a difference.
The fix is to add an ORDER BY for the main query when we could expect
a non-deterministic order and when the child query of the UDF uses
ORDER BY.
@DaveBirdsall suggested that we could also change the logsort program to
recognize different types of ORDER BY, but this is probably not needed
right now.