This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-2662] Remove some non-determinism from compGeneral/TEST023 #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1917/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1917/ |
|
The test failure was in seabase/TEST010, which I believe has been addressed separately by #1161. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another attempt to fix compGeneral/TEST023. The sample table names generated for persistent sample tables could vary in length, as they were functions of object UIDs and timestamps. The changes here pad these numbers with leading zeroes out to a fixed length, which should eliminate variability in line wrap in the test results. While I was at it, I found a bug: there was a buffer overrun in this code (my bad); the buffer is now the proper length.