TRAFODION-2724 #1216
TRAFODION-2724 #1216
Conversation
…t operation is done and the exact length of data is passed in to be extracted.
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-release2.2/5/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-release2.2/5/ |
core/sql/exp/ExpLOBaccess.cpp
Outdated
| if (operLen == tgtSize) | ||
| { | ||
| //The cursor still has data available but wait until redrive since | ||
| //we have fetched all the data for this extract operation |
There was a problem hiding this comment.
The comment seems to be confusing. What is being waited to do until re-driven?
There was a problem hiding this comment.
The cursor on the full lob data indicates that there is data left. But the extract operation can retrieve justt a portion of the total. The state is maintained in the cursor and will get updated with each "execute" of the extract statement issued by caller of the extract statement. Agree this comment is confusing. I can just say "return the data to caller".
|
Let me rework this a bit so it is explicitly clear as to where we are closing the internal cursor on the descriptor table. Will make it more readable and easier to maintain. Please don't merge yet. |
Added a method for JDBC driver to be able to close an open cursor abruptly by passing in a 0 length to the extract syntax. This will ensure internal opens are not left around if the application does not retrieve all the data with the stream API. This abrupt close can be called when the result set is closed or the connection is closed by keeping track of all the open Blob objects. (in the driver) Added a freeResources method and destructor to LobExtract and LobUpdate Tcbs. Minor changes and fixes : Refactored the ExLob::closeCursor Removed the LOB_CLI_SELECT_CLOSE call from ::fetchCursor so it gets closed only when ExLob::closeCursor is called. Makes the code consistent and readable. Took care of a few memory allocations and deletions. Refactored the LOB length calculation into on ecommon method so it works correctly for both regular LOB dat aas well as external LOB files. Earlier the external lobs length was being returned incorrectly. Now it reports the length of the external HDFS file . Fixed one place in generator where the CQD value was not being multiplied by the MB units correctly.
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-release2.2/6/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-release2.2/6/ |
|
+1 |
Fix to ensure internal statements used to retrieve LOB descriptor chunks information during an extract are closed properly. The issue was if the the caller of extract passed in the exact length, the ""readCursorData method would return the correct data but would leave the "open" to the internal table in a FETCH state. This change ensures that a second "fetch" is done so EOD would be seen and as a result the internal statement would get closed within the method ExLob::fethCursor which would call SQL_EXEC_LOBcliInterface(handleIn, handleLenIn, ....
LOB_CLI_SELECT_CLOSE, .....)