Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

TRAFODION-2731 CodeCleanup: Remove obsolete, legacy and unused code #1226

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

anoopsharma00
Copy link
Contributor

This phase handles the following:

-- removal of code that dealt with:
-- mpalias, NSK, MP, mploc, resource fork, rfork
-- ARLIB, DISK, VOLUME, PFS, compiler version info
-- interpretasrow/IAR, AuditImage, ExtractColumns functions
-- ARKCMP_SINGLE_PROCESS and oneProcess()
-- recompControl, remoteDefaults, rtdu, module
-- latebind thru nsk defines, guardian names, nametype nsk
-- SHADOW implementation
-- MEASURE
-- older sqlcat ReadTableDef
-- DP2_MEMORY, DP2_SPACE, HGB_DP2_MEMORY_LIMIT
-- internal cli methods no longer used by any caller

Code within the following defines is removed if it is obsolete
or the define itself is removed if that feature is always on:
-- removed NA_EIDPROC
-- removed SQLEXP_LIB_FUNC
-- removed NA_CMPDLL
-- removed SQ_PHANDLE_VERIFIER
-- removed SQ_NEW_PHANDLE
-- removed __EID
-- removed ARKFS_OPEN
-- removed STAND_ALONE
-- removed __TANDEM
-- removed NA_C89
-- removed NA_NSK
-- removed SQLEXPORT_LIB_FUNC
-- removed SQLCLI_LIB_FUNC
-- removed CLI_PRIV_SRL
-- removed PRIV_SRL
-- removed NA_LINUX
-- removed NA_HSC_LINUX
-- removed NA_UNIX
-- removed NA_WINNT
-- removed HAVE_MMAP
-- removed NA_NO_C_RUNTIME
-- removed NA_DEBUG_C_RUNTIME(replaced with _DEBUG)
-- removed NA_64BIT usage except in sqlcli.h
-- removed dg64
-- removed SQLEXPORT_LIB
-- removed NA_ARKFS
-- removed NA_IEEE_FLOAT
-- removed NA_GUARDIAN_MSG
-- removed NA_HSC
-- removed NA_TMFNOTYETSUPPORTED
-- removed ERROR
-- removed ERROR_STATE
-- removed SQLERRORS_LIB_FUNC

Contents of these files have been removed.
Next checkin fill remove the files itself from git:
executor/dmeasql.h
executor/ExMeas.h, ExMeas.cpp
executor/tempfile.h, .cpp
executor/rcb.h
executor/stubs.cpp, stubs2.cpp
exp/srlversion.cpp
cli/rtdu.h, rtdu2.h, rtdu.cpp, rtdu.cpp
cli/VicKeyValuePair.h
cli/CliDll.cpp
cli/CliStubsStaticBuild.cpp
cli/globalsrlversion.cpp
cli/globalstubs.cpp
cli/sqlciSRLStubs.cpp
cli/test.cpp
cli/privsrlversion.cpp
common/SqlExpDllDefines.h
common/SqlExportDllDefines.h
sqlcat/enum.h
sqlcat/ReadTableDef.h, cpp
sqlcat/readRealArk.h, cpp

This phase handles the following:

-- removal of code that dealt with:
   -- mpalias, NSK, MP, mploc, resource fork, rfork
   -- ARLIB, DISK, VOLUME, PFS, compiler version info
   -- interpretasrow/IAR, AuditImage, ExtractColumns functions
   -- ARKCMP_SINGLE_PROCESS and oneProcess()
   -- recompControl, remoteDefaults, rtdu,  module
   -- latebind thru nsk defines, guardian names, nametype nsk
   -- SHADOW implementation
   -- MEASURE
   -- older sqlcat ReadTableDef
   -- DP2_MEMORY, DP2_SPACE, HGB_DP2_MEMORY_LIMIT
   -- internal cli methods no longer used by any caller

Code within the following defines is removed if it is obsolete
or the define itself is removed if that feature is always on:
   -- removed NA_EIDPROC
   -- removed SQLEXP_LIB_FUNC
   -- removed NA_CMPDLL
   -- removed SQ_PHANDLE_VERIFIER
   -- removed SQ_NEW_PHANDLE
   -- removed __EID
   -- removed ARKFS_OPEN
   -- removed STAND_ALONE
   -- removed  __TANDEM
   -- removed NA_C89
   -- removed NA_NSK
   -- removed SQLEXPORT_LIB_FUNC
   -- removed SQLCLI_LIB_FUNC
   -- removed CLI_PRIV_SRL
   -- removed PRIV_SRL
   -- removed NA_LINUX
   -- removed NA_HSC_LINUX
   -- removed NA_UNIX
   -- removed NA_WINNT
   -- removed HAVE_MMAP
   -- removed NA_NO_C_RUNTIME
   -- removed NA_DEBUG_C_RUNTIME(replaced with _DEBUG)
   -- removed NA_64BIT usage except in sqlcli.h
   -- removed dg64
   -- removed SQLEXPORT_LIB
   -- removed NA_ARKFS
   -- removed NA_IEEE_FLOAT
   -- removed NA_GUARDIAN_MSG
   -- removed NA_HSC
   -- removed NA_TMFNOTYETSUPPORTED
   -- removed ERROR
   -- removed ERROR_STATE
   -- removed SQLERRORS_LIB_FUNC

Contents of these files have been removed.
Next checkin fill remove the files itself from git:
  executor/dmeasql.h
  executor/ExMeas.h, ExMeas.cpp
  executor/tempfile.h, .cpp
  executor/rcb.h
  executor/stubs.cpp, stubs2.cpp
  exp/srlversion.cpp
  cli/rtdu.h, rtdu2.h, rtdu.cpp, rtdu.cpp
  cli/VicKeyValuePair.h
  cli/CliDll.cpp
  cli/CliStubsStaticBuild.cpp
  cli/globalsrlversion.cpp
  cli/globalstubs.cpp
  cli/sqlciSRLStubs.cpp
  cli/test.cpp
  cli/privsrlversion.cpp
  common/SqlExpDllDefines.h
  common/SqlExportDllDefines.h
  sqlcat/enum.h
  sqlcat/ReadTableDef.h, cpp
  sqlcat/readRealArk.h, cpp
@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2034/

@Traf-Jenkins
Copy link

@zellerh
Copy link
Contributor

zellerh commented Sep 7, 2017

+1
You can imagine that I didn't look at every changed line, but all the places I checked looked good. Thanks a lot for this big cleanup effort!

@asfgit asfgit merged commit 1522c8c into apache:master Sep 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants